Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation
From: Oleksandr Mazur <hidden>
Date: 2021-06-16 16:07:25
Also in:
lkml
Subject: Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation
On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote:
> + debugfs_create_bool("fail_trap_counter_get", 0600,
The test is doing:
echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get
And fails with:
./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//fail_trap_drop_counter_get: Permission denied
Please fix netdevsim to instantiate the correct file and avoid submitting new tests without running them first.
Sorry for that. I've actually run the test, but the problem is during patch preparation the naming convention for the counter itself changed (and i've missed the debugfs file name to get changed as well), and i've run the test before it was changed. I will send the fix, thank you.