Thread (2 messages) flat view 2 messages, 2 authors, 2021-06-16

Re: [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs()

From: Leon Romanovsky <leon@kernel.org>
Date: 2021-06-16 06:19:42
Also in: linux-rdma, lkml

On Tue, Jun 15, 2021 at 06:58:15PM +0800, Jiapeng Chong wrote:
The error code is missing in this code scenario, add the error code
'-ENOMEM' to the return value 'err'.

Eliminate the follow smatch warning:

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs()
warn: missing error code 'err'.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Can you please add fixes lines to your patches like all fix patches should?

Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all firmware steering")

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help