Re: [PATCH net-next] net: dsa: xrs700x: forward HSR supervision frames

On Tue, Jun 15, 2021 at 6:22 PM Vladimir Oltean [off-list ref] wrote:

On Tue, Jun 15, 2021 at 12:55:26PM -0500, George McCollister wrote:

quoted

Forward supervision frames between redunant HSR ports. This was broken
in the last commit.

Fixes: 1a42624aecba ("net: dsa: xrs700x: allow HSR/PRP supervision dupes
for node_table")

It would be good if you could resend with the Fixes: line not wrapped
around. There are several scripts around which won't parse that.

WIll do. I was wondering which way was correct and figured scripts
should be smart enough to parse it especially since all it should
really need is Fixes: $HASH. Oh well.

quoted

Signed-off-by: George McCollister <george.mccollister@gmail.com>
---

Otherwise the change looks reasonably clean, and it agrees with what IEC
62439-3:2018 does seem to imply in "5.3.4 DANH forwarding rules" that
HSR_Supervision frames should be forwarded and without discarding
duplicates. For PRP, of course the DANP does not forward packets between
the redundant ports, so it does not forward PRP_Supervision packets
either.

Yeah the tricky part with HSR supervision frames is you must forward
if the other port has received the duplicate frame but not if the
frame has been sent out the port you're about to send from already. At
first I set the mirror bit in addition to the allow bit and activity
was on completely solid as supervision frames looped around.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Thanks