Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support

On Tue, Jun 15, 2021 at 6:09 PM Marcin Wojtas [off-list ref] wrote:

niedz., 13 cze 2021 o 22:08 Andy Shevchenko
[off-list ref] napisał(a):

quoted

On Sunday, June 13, 2021, Andrew Lunn [off-list ref] wrote:

quoted

The better approach is to switch to devm_get_clk_optional() as I have done in several drivers, IIRC recently in mvpp2

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=cf3399b731d36bc780803ff63e4d480a1efa33ac

Yes, this would be a nice improvement, however the
devm_get_clk_optional requires clock name (type char *) - mvmdio uses
raw indexes, so this helper unfortunately seems to be not applicable.

As far as I can read the code it smells like devm_clk_bulk_get_optional().
Am I mistaken?

-- 
With Best Regards,
Andy Shevchenko