Re: [PATCH v5] ping: Check return value of function 'ping_queue_rcv_skb'

On 6/9/21 7:41 PM, Zheng Yongjun wrote:

Function 'ping_queue_rcv_skb' not always return success, which will
also return fail. If not check the wrong return value of it, lead to function
`ping_rcv` return success.

Signed-off-by: Zheng Yongjun <redacted>
---
v2:
- use rc as return value to make code look cleaner
v3:
- delete unnecessary braces {}
v4:
- put variable 'rc' declaration at the beginning of function
v5:
- don/t print unneed debuginfo in the right path
 net/ipv4/ping.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: David Ahern <dsahern@kernel.org>