From: Tom Rix <trix@redhat.com>
A followup to
https://lore.kernel.org/linux-fpga/YMD2yxtsQN16MoPA@kroah.com/
So I do not repeat this problem, add a SPDX checker for Makefiles and
Kconfigs to checkpatch.
Then treewide fix the malformed Makefiles and Kconfigs.
Those missing tags are numerous.
Kconfig has 46
Makefile has 141
Run checkpatch generally over the dirs with Makefile or Kconfig problems
to check nothing broke in checkpatch. Fix the few problems turned up
Tom Rix (7):
checkpatch: check Makefiles and Kconfigs for SPDX tag
mei: hdcp: SPDX tag should be the first line
drivers/soc/litex: fix spelling of SPDX tag
MIPS: Loongson64: fix spelling of SPDX tag
iio/scmi: fix spelling of SPDX tag
mt76: add a space between comment char and SPDX tag
mt76: use SPDX header file comment style
arch/mips/boot/dts/loongson/Makefile | 2 +-
drivers/iio/common/scmi_sensors/Makefile | 2 +-
drivers/misc/mei/hdcp/Kconfig | 1 -
drivers/net/wireless/mediatek/mt76/mt7615/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7615/sdio.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/testmode.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt7921/Makefile | 2 +-
drivers/soc/litex/Kconfig | 2 +-
drivers/soc/litex/Makefile | 2 +-
scripts/checkpatch.pl | 2 +-
11 files changed, 10 insertions(+), 11 deletions(-)
--
2.26.3
From: Tom Rix <trix@redhat.com>
Both Makefiles and Kconfigs should carry an SPDX tag.
Something like
# SPDX-License-Identifier: GPL-2.0-only
Add a matcher to existing check
Signed-off-by: Tom Rix <trix@redhat.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -3572,7 +3572,7 @@ sub process {$comment='/*';}elsif($realfile=~/\.(c|dts|dtsi)$/){$comment='//';-}elsif(($checklicenseline==2)||$realfile=~/\.(sh|pl|py|awk|tc|yaml)$/){+}elsif(($checklicenseline==2)||$realfile=~/\.(sh|pl|py|awk|tc|yaml)$|Kconfig|Makefile/){$comment='#';}elsif($realfile=~/\.rst$/){$comment='..';
From: Tom Rix <trix@redhat.com>
checkpatch looks for the tag on the first line.
So delete empty first line
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/misc/mei/hdcp/Kconfig | 1 -
1 file changed, 1 deletion(-)
From: Tom Rix <trix@redhat.com>
checkpatch looks for SPDX-License-Identifier.
So change the '_' to '-'
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/mips/boot/dts/loongson/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Joe Perches <joe@perches.com> Date: 2021-06-10 22:15:21
On Thu, 2021-06-10 at 14:44 -0700, trix@redhat.com wrote:
From: Tom Rix <trix@redhat.com>
Both Makefiles and Kconfigs should carry an SPDX tag.
Something like
# SPDX-License-Identifier: GPL-2.0-only
Add a matcher to existing check
Signed-off-by: Tom Rix <trix@redhat.com>
Seems fine, thanks.
There's a Makefile with two tags that could be updated too.
---
drivers/staging/media/atomisp/Makefile | 1 -
1 file changed, 1 deletion(-)
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Date: 2021-06-21 09:54:40
On Thu, Jun 10, 2021 at 02:44:35PM -0700, trix@redhat.com wrote:
From: Tom Rix <trix@redhat.com>
checkpatch looks for SPDX-License-Identifier.
So change the '_' to '-'
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/mips/boot/dts/loongson/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]