Thread (5 messages) flat view 5 messages, 4 authors, 2021-06-11

Re: [PATCH] soc: qcom: ipa: Remove superfluous error message around platform_get_irq()

From: David Miller <davem@davemloft.net>
Date: 2021-06-10 21:11:50
Also in: lkml

From:  Zhongjun Tan <redacted>
Date: Thu, 10 Jun 2021 22:01:18 +0800
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
index 34b68dc43886..93270e50b6b3 100644
--- a/drivers/net/ipa/ipa_smp2p.c
+++ b/drivers/net/ipa/ipa_smp2p.c
@@ -177,11 +177,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
 	int ret;
 
 	ret = platform_get_irq_byname(smp2p->ipa->pdev, name);
-	if (ret <= 0) {
-		dev_err(dev, "DT error %d getting \"%s\" IRQ property\n",
-			ret, name);
+	if (ret <= 0)
Applied, but this code still rejects an irq of zero which is a valid irq number.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help