Thread (6 messages) flat view 6 messages, 4 authors, 2021-06-10

Re: [PATCH][next] net: dsa: sja1105: Fix assigned yet unused return code rc

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-06-09 18:00:28
Also in: kernel-janitors, lkml

On Wed, Jun 09, 2021 at 06:43:53PM +0100, Colin King wrote:
From: Colin Ian King <redacted>

The return code variable rc is being set to return error values in two
places in sja1105_mdiobus_base_tx_register and yet it is not being
returned, the function always returns 0 instead. Fix this by replacing
the return 0 with the return code rc.

Addresses-Coverity: ("Unused value")
Fixes: 5a8f09748ee7 ("net: dsa: sja1105: register the MDIO buses for 100base-T1 and 100base-TX")
Signed-off-by: Colin Ian King <redacted>
---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help