Re: [PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()
From: Saeed Mahameed <saeed@kernel.org>
Date: 2021-06-09 01:34:04
Also in:
linux-rdma, lkml
On Fri, 2021-06-04 at 18:08 +0800, Yang Li wrote:
When the code execute 'if (!priv->fs.arfs->wq)', the value of err is
0.
So, we use -ENOMEM to indicate that the function
create_singlethread_workqueue() return NULL.
Clean up smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
mlx5e_arfs_create_tables() warn: missing error code 'err'.
Reported-by: Abaci Robot <redacted>
Fixes: f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev
when needed")
Signed-off-by: Yang Li <redacted>
---
Changes in v2:
--According to Saeed's suggestion, we modify the format of Fixes tag,
--and initialize err to -ENOMEM.
https://lore.kernel.org/patchwork/patch/1440018/applied to net-mlx5. thanks !