Re: [PATCH 1/2][next] net: usb: asix: Fix less than zero comparison of a u16
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-06-08 17:58:32
Also in:
kernel-janitors, linux-usb, lkml
On Tue, Jun 08, 2021 at 04:22:48PM +0100, Colin King wrote:
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted> The comparison of the u16 priv->phy_addr < 0 is always false because phy_addr is unsigned. Fix this by assigning the return from the call to function asix_read_phy_addr to int ret and using this for the less than zero error check comparison. Addresses-Coverity: ("Unsigned compared against 0") Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") Signed-off-by: Colin Ian King <redacted> --- drivers/net/usb/asix_devices.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 57dafb3262d9..211c5a87eb15 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c@@ -704,9 +704,10 @@ static int ax88772_init_phy(struct usbnet *dev) struct asix_common_private *priv = dev->driver_priv; int ret; - priv->phy_addr = asix_read_phy_addr(dev, true); - if (priv->phy_addr < 0) + ret = asix_read_phy_addr(dev, true); + if (ret < 0) return priv->phy_addr;
please add new line here
+ priv->phy_addr = ret; snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT, priv->mdio->id, priv->phy_addr); -- 2.31.1
Thank you! Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |