Re: [PATCH] libbpf: Fixes incorrect rx_ring_setup_done

On Mon, Jun 7, 2021 at 8:04 AM Yonghong Song [off-list ref] wrote:

On 6/7/21 6:08 AM, Kev Jackson wrote:

quoted

When calling xsk_socket__create_shared(), the logic at line 1097 marks a
boolean flag true within the xsk_umem structure to track setup progress
in order to support multiple calls to the function.  However, instead of
marking umem->tx_ring_setup_done, the code incorrectly sets
umem->rx_ring_setup_done.  This leads to improper behaviour when
creating and destroying xsk and umem structures.

Multiple calls to this function is documented as supported.

Signed-off-by: Kev Jackson <redacted>

Acked-by: Yonghong Song <redacted>

Applied to bpf tree, thanks. Also added

Fixes: ca7a83e2487a ("libbpf: Only create rx and tx XDP rings when necessary")

Please don't forget Fixes: tag in the future.