Re: [RESEND net-next 1/2] net: hns3: add support for PTP

On 2021/6/5 23:53, Richard Cochran wrote:

On Sat, Jun 05, 2021 at 06:37:19PM +0800, huangguangbin (A) wrote:

quoted

quoted

Need mutex or spinlock to protest against concurrent access.

Ok, thank you. Is it better to add mutex or spinlock in the public place, like ptp_clock_adjtime()?
Then there's no need to add mutex or spinlock in all the drives.

No, that is a terrible idea.  The class layer has no idea about the
hardware implementation.  Only the driver knows that.

Thanks,
Richard
.

Ok, thanks. We will add mutex or spinlock as your idea, and repost a new version after we test ok.