Re: [PATCH net-next v7 4/5] mvpp2: recycle buffers

On Fri, Jun 4, 2021 at 9:48 PM Matthew Wilcox [off-list ref] wrote:

On Fri, Jun 04, 2021 at 08:33:48PM +0200, Matteo Croce wrote:

quoted

+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

@@ -3997,7 +3997,7 @@ static int mvpp2_rx(struct mvpp2_port *port, struct napi_struct *napi,
              }

              if (pp)
-                     page_pool_release_page(pp, virt_to_page(data));
+                     skb_mark_for_recycle(skb, virt_to_page(data), pp);

Does this driver only use order-0 pages?  Should it be using
virt_to_head_page() here?  or should skb_mark_for_recycle() call
compound_head() internally?

This driver uses only order-0 pages.

-- 
per aspera ad upstream