Thread (3 messages) flat view 3 messages, 3 authors, 2021-06-07

Re: [PATCH net-next v2] net: lantiq: Use devm_platform_get_and_ioremap_resource()

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: 2021-06-05 12:49:50
Also in: lkml

On 6/5/21 2:21 PM, Yang Yingliang wrote:
Use devm_platform_get_and_ioremap_resource() to simplify
code.

Signed-off-by: Yang Yingliang <redacted>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
quoted hunk ↗ jump to hunk
---
v2:
   remove 'res'
---
  drivers/net/ethernet/lantiq_xrx200.c | 9 +--------
  1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
index 36dc3e5f6218..27df06ed355e 100644
--- a/drivers/net/ethernet/lantiq_xrx200.c
+++ b/drivers/net/ethernet/lantiq_xrx200.c
@@ -436,7 +436,6 @@ static int xrx200_probe(struct platform_device *pdev)
  {
  	struct device *dev = &pdev->dev;
  	struct device_node *np = dev->of_node;
-	struct resource *res;
  	struct xrx200_priv *priv;
  	struct net_device *net_dev;
  	int err;
@@ -456,13 +455,7 @@ static int xrx200_probe(struct platform_device *pdev)
  	net_dev->max_mtu = XRX200_DMA_DATA_LEN;
  
  	/* load the memory ranges */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		dev_err(dev, "failed to get resources\n");
-		return -ENOENT;
-	}
-
-	priv->pmac_reg = devm_ioremap_resource(dev, res);
+	priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
  	if (IS_ERR(priv->pmac_reg))
  		return PTR_ERR(priv->pmac_reg);
  
  

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help