Re: [PATCH] ipv6: parameter p.name is empty
From: Nicolas Dichtel <hidden>
Date: 2021-06-03 16:31:02
Also in:
lkml
Le 03/06/2021 à 17:15, David Ahern a écrit :
On 6/3/21 7:33 AM, Nicolas Dichtel wrote:quoted
Le 03/06/2021 à 11:50, zhang kai a écrit :quoted
so do not check it. Signed-off-by: zhang kai <redacted> --- net/ipv6/addrconf.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index b0ef65eb9..4c6b3fc7e 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c@@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, if (err) return err; - dev = __dev_get_by_name(net, p.name); - if (!dev) - return -ENOBUFS; return dev_open(dev, NULL); }This bug seems to exist since the beginning of the SIT driver (24 years!): https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a Search addrconf_set_dstaddr() Acked-by: Nicolas Dichtel <redacted>A patch was sent yesterday, "sit: set name of device back to struct parms", to set the name field in params.
Oh yes, it was in my spam folder ...