Re: [PATCH] nfc: mrvl: remove useless "continue" at end of loop

On 01/06/2021 18:30, Joe Perches wrote:

On Tue, 2021-06-01 at 18:07 +0200, Krzysztof Kozlowski wrote:

quoted

The "continue" statement at the end of a for loop does not have an
effect.

[]

quoted

diff --git a/drivers/nfc/nfcmrvl/usb.c b/drivers/nfc/nfcmrvl/usb.c

[]

quoted

@@ -325,7 +325,6 @@ static int nfcmrvl_probe(struct usb_interface *intf,

 		if (!drv_data->bulk_rx_ep &&
 		    usb_endpoint_is_bulk_in(ep_desc)) {
 			drv_data->bulk_rx_ep = ep_desc;
-			continue;
 		}
 	}

I think this code would be clearer with an if/else instead of
multiple continues.

Makes sense. I'll send a v2.


Best regards,
Krzysztof