RE: [PATCH net-next 2/4] net: phy: realtek: add dt property to disable CLKOUT clock

Hi Andrew,

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: 2021年6月2日 6:08
To: Joakim Zhang <redacted>
Cc: davem@davemloft.net; kuba@kernel.org; robh+dt@kernel.org;
hkallweit1@gmail.com; linux@armlinux.org.uk; f.fainelli@gmail.com;
dl-linux-imx [off-list ref]; netdev@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: phy: realtek: add dt property to disable
CLKOUT clock

quoted

+struct rtl821x_priv {
+	u32 quirks;

I'm not sure quirks is the correct word here. I would probably use features, or
flags.

Ok, I will change to flags.

As Russell king suggests another solution, which would you prefer to?
I need a conclusion so that I can send out the V2, thanks.

Best Regards,
Joakim Zhang

	  Andrew