Re: [PATCH] NFC: nci: Remove redundant assignment to len
From: Krzysztof Kozlowski <hidden>
Date: 2021-06-01 10:11:23
Also in:
lkml, oe-linux-nfc
On 01/06/2021 11:49, Yang Li wrote:
quoted hunk ↗ jump to hunk
Variable 'len' is set to conn_info->max_pkt_payload_len but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Clean up the following clang-analyzer warning: net/nfc/nci/hci.c:164:3: warning: Value stored to 'len' is never read [clang-analyzer-deadcode.DeadStores] Reported-by: Abaci Robot <redacted> Signed-off-by: Yang Li <redacted> --- net/nfc/nci/hci.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c index 9686514..d6732e5 100644 --- a/net/nfc/nci/hci.c +++ b/net/nfc/nci/hci.c@@ -161,8 +161,6 @@ static int nci_hci_send_data(struct nci_dev *ndev, u8 pipe, *(u8 *)skb_push(skb, 1) = data_type; do { - len = conn_info->max_pkt_payload_len; - /* If last packet add NCI_HFP_NO_CHAINING */ if (i + conn_info->max_pkt_payload_len - (skb->len + 1) >= data_len) {
Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof