Thread (2 messages) flat view 2 messages, 2 authors, 2021-06-29

Re: [PATCH net] net: ipv6: fix return value of ip6_skb_dst_mtu

From: David Ahern <hidden>
Date: 2021-06-29 03:20:23

On 6/28/21 3:54 PM, Vadim Fedorenko wrote:
Commit 628a5c561890 ("[INET]: Add IP(V6)_PMTUDISC_RPOBE") introduced
ip6_skb_dst_mtu with return value of signed int which is inconsistent
with actually returned values. Also 2 users of this function actually
assign its value to unsigned int variable and only __xfrm6_output
assigns result of this function to signed variable but actually uses
as unsigned in further comparisons and calls. Change this function
to return unsigned int value.

Fixes: 628a5c561890 ("[INET]: Add IP(V6)_PMTUDISC_RPOBE")
Signed-off-by: Vadim Fedorenko <redacted>
---
 include/net/ip6_route.h | 2 +-
 net/ipv6/xfrm6_output.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: David Ahern <dsahern@kernel.org>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help