Re: [PATCH net-next 0/7] ethtool: Module EEPROM API improvements

On Tue, Jun 22, 2021 at 09:30:05AM -0700, Jakub Kicinski wrote:

On Tue, 22 Jun 2021 09:50:45 +0300 Ido Schimmel wrote:

quoted

From: Ido Schimmel <idosch@nvidia.com>

This patchset contains various improvements to recently introduced
module EEPROM netlink API. Noticed these while adding module EEPROM
write support.

Scary that 3/7 was not generating a warning.

Actually, it's not as scary as it seems. If an array variable is
declared with fixed size and then defined and initialized with just
"[]", the number of elements is still taken from the declaration, not
from the maximum initializer index. So there was nothing to worry about,
we just had a partially initialized array with extra elements zero
initialized.

Michal