Re: [PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow | netdev | Ratatoskr

[PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow · Dan Carpenter <hidden> · 2021-06-19
Re: [PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow · Florian Westphal <fw@strlen.de> · 2021-06-20
Re: [PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow · Pablo Neira Ayuso <pablo@netfilter.org> · 2021-06-21

Re: [PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow

From: Florian Westphal <fw@strlen.de>
Date: 2021-06-20 20:45:56
Also in: kernel-janitors, netfilter-devel

Dan Carpenter [off-list ref] wrote:

The kernel version of snprintf() can't return negatives.  The
"ret > (int)sizeof(sym)" check is off by one because and it should be

quoted

=.  Finally, we need to set a negative error code.

Reviewed-by: Florian Westphal <fw@strlen.de>