Re: [PATCH net-next v5 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver

Hi Michael,

On Sat, Jun 19, 2021 at 9:31 PM Michael Schmitz [off-list ref] wrote:

Am 19.06.2021 um 21:08 schrieb Geert Uytterhoeven:

quoted

On Sat, Jun 19, 2021 at 2:35 AM Michael Schmitz [off-list ref] wrote:

quoted

Add Kconfig option, module parameter and PCMCIA reset code
required to support 100 Mbit PCMCIA ethernet cards on Amiga.

10 Mbit and 100 Mbit mode are supported by the same module.
A module parameter switches Amiga ISA IO accessors to word
access by changing isa_type at runtime. Additional code to
reset the PCMCIA hardware is also added to the driver probe.

Patch modified after patch "[PATCH RFC net-next] Amiga PCMCIA
100 MBit card support" submitted to netdev 2018/09/16 by Alex
Kazik [off-list ref].

CC: netdev@vger.kernel.org
Link: https://lore.kernel.org/r/1622958877-2026-1-git-send-email-schmitzmic@gmail.com (local)
Tested-by: Alex Kazik <redacted>
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>

Thanks for your patch!

Note that this patch has a hard dependency on "[PATCH v5 1/2] m68k:
io_mm.h - add APNE 100 MBit support" in the series, so it must not
be applied to the netdev tree yet.

Hmm - so we ought to protect the new code by

#ifdef ARCH_HAVE_16BIT_PCMCIA

and set that in the m68k machine Kconfig in the first patch?

(It's almost, but not quite like a config option :-)

No, we just manage dependencies, so either:
  1. Patch 2 cannot go in until patch 1 is upstream,
  2. One subsystem maintainer gives an Acked-by for one patch,so
    the other subsystem maintainer can apply both patches.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds