Thread (4 messages) flat view 4 messages, 3 authors, 2021-06-18

Re: [PATCH net v2 1/2] icmp: don't send out ICMP messages with a source address of 0.0.0.0

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-18 19:20:07

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 18 Jun 2021 13:04:35 +0200 you wrote:
When constructing ICMP response messages, the kernel will try to pick a
suitable source address for the outgoing packet. However, if no IPv4
addresses are configured on the system at all, this will fail and we end up
producing an ICMP message with a source address of 0.0.0.0. This can happen
on a box routing IPv4 traffic via v6 nexthops, for instance.

Since 0.0.0.0 is not generally routable on the internet, there's a good
chance that such ICMP messages will never make it back to the sender of the
original packet that the ICMP message was sent in response to. This, in
turn, can create connectivity and PMTUd problems for senders. Fortunately,
RFC7600 reserves a dummy address to be used as a source for ICMP
messages (192.0.0.8/32), so let's teach the kernel to substitute that
address as a last resort if the regular source address selection procedure
fails.

[...]
Here is the summary with links:
  - [net,v2,1/2] icmp: don't send out ICMP messages with a source address of 0.0.0.0
    https://git.kernel.org/netdev/net/c/321827477360
  - [net,v2,2/2] selftests/net: Add icmp.sh for testing ICMP dummy address responses
    https://git.kernel.org/netdev/net/c/7e9838b7915e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help