Thread (2 messages) flat view 2 messages, 2 authors, 2021-06-18

Re: [PATCH] vhost-vdpa: fix bug-"v->vqs" and "v" don't free

From: Jason Wang <hidden>
Date: 2021-06-18 07:20:34
Also in: kvm, virtualization

在 2021/6/18 下午2:53, Cai Huoqing 写道:
quoted hunk ↗ jump to hunk
"v->vqs" and "v" don't free when "cdev_device_add" returns error

Signed-off-by: Cai Huoqing <redacted>
---
  drivers/vhost/vdpa.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index fb41db3da611..6e5d5df5ee70 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -1065,6 +1065,8 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa)
  
  err:
         put_device(&v->dev);
+       kfree(v->vqs);
+       kfree(v);

Isn't this the charge of vhost_vdpa_release_dev()?

Thanks

         return r;
  }
  
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help