Re: [PATCH net] ethtool: strset: Fix reply_size value
From: Ido Schimmel <hidden>
Date: 2021-06-17 16:29:17
On Thu, Jun 17, 2021 at 06:42:52PM +0300, Amit Cohen wrote:
strset_reply_size() does not take into account the size required for the
'ETHTOOL_A_STRSET_STRINGSETS' nested attribute.
Since commit 4d1fb7cde0cc ("ethtool: add a stricter length check") this
results in the following warning in the kernel log:
ethnl cmd 1: calculated reply length 2236, but consumed 2240
WARNING: CPU: 2 PID: 30549 at net/ethtool/netlink.c:360 ethnl_default_doit+0x29f/0x310
Add the appropriate size to the calculation.
Fixes: 71921690f974 ("ethtool: provide string sets with STRSET_GET request")
Signed-off-by: Amit Cohen <redacted>
Reviewed-by: Jiri Pirko <redacted>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
Ha, seems this is addressed by commit e175aef90269 ("ethtool: strset:
fix message length calculation") in net.git which actually motivated
commit 4d1fb7cde0cc ("ethtool: add a stricter length check").
The former is still not in net-next.git, which is why the warning is
triggered there.
The patch can be dropped.