Thread (3 messages) flat view 3 messages, 2 authors, 2021-06-15

Re: [PATCH] qmi_wwan: Do not call netif_rx from rx_fixup

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-15 18:30:07

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 15 Jun 2021 12:01:51 +0200 you wrote:
When the QMI_WWAN_FLAG_PASS_THROUGH is set, netif_rx() is called from
qmi_wwan_rx_fixup(). When the call to netif_rx() is successful (which is
most of the time), usbnet_skb_return() is called (from rx_process()).
usbnet_skb_return() will then call netif_rx() a second time for the same
skb.

Simplify the code and avoid the redundant netif_rx() call by changing
qmi_wwan_rx_fixup() to always return 1 when QMI_WWAN_FLAG_PASS_THROUGH
is set. We then leave it up to the existing infrastructure to call
netif_rx().

[...]
Here is the summary with links:
  - qmi_wwan: Do not call netif_rx from rx_fixup
    https://git.kernel.org/netdev/net/c/057d49334c02

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help