Re: [PATCH net-next] r8169: avoid link-up interrupt issue on RTL8106e if user enables ASPM
From: Koba Ko <hidden>
Date: 2021-06-11 08:04:25
On Fri, Jun 11, 2021 at 4:57 AM Heiner Kallweit [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It has been reported that on RTL8106e the link-up interrupt may be significantly delayed if the user enables ASPM L1. Per default ASPM is disabled. The change leaves L1 enabled on the PCIe link (thus still allowing to reach higher package power saving states), but the NIC won't actively trigger it. Reported-by: Koba Ko <redacted> Tested-by: Koba Ko <redacted> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 64f94a3fe..6a9fe9f7e 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c@@ -3508,7 +3508,6 @@ static void rtl_hw_start_8106(struct rtl8169_private *tp) rtl_eri_write(tp, 0x1b0, ERIAR_MASK_0011, 0x0000); rtl_pcie_state_l2l3_disable(tp); - rtl_hw_aspm_clkreq_enable(tp, true); }
As per 0866cd15029b, this also affects the intel soc idle state. Even the result is positive currently, I think this modification would have higher risk.
DECLARE_RTL_COND(rtl_mac_ocp_e00e_cond) -- 2.32.0