Thread (6 messages) 6 messages, 3 authors, 2021-06-10

Re: [PATCH net v2 1/3] netfilter: synproxy: Fix out of bounds when parsing TCP options

flat view

From: Florian Westphal <fw@strlen.de>
Date: 2021-06-10 16:44:14
Also in: mptcp

Maxim Mikityanskiy [off-list ref] wrote:
The TCP option parser in synproxy (synproxy_parse_options) could read
one byte out of bounds. When the length is 1, the execution flow gets
into the loop, reads one byte of the opcode, and if the opcode is
neither TCPOPT_EOL nor TCPOPT_NOP, it reads one more byte, which exceeds
the length of 1.

This fix is inspired by commit 9609dad263f8 ("ipv4: tcp_input: fix stack
out of bounds when parsing TCP options.").
Reviewed-by: Florian Westphal <fw@strlen.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help