Thread (4 messages) flat view 4 messages, 2 authors, 2021-06-03
STALE1895d

[PATCH net-next 2/2] net/smc: no need to flush smcd_dev's event_wq before destroying it

From: Karsten Graul <hidden>
Date: 2021-06-02 08:56:44
Also in: linux-s390
Subsystem: networking [general], shared memory communications (smc) sockets, the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, D. Wythe, Dust Li, Sidraya Jayagond, Mahanta Jambigi, Linus Torvalds

From: Julian Wiedmann <redacted>

destroy_workqueue() already calls drain_workqueue(), which is a stronger
variant of flush_workqueue().

Signed-off-by: Julian Wiedmann <redacted>
Signed-off-by: Karsten Graul <redacted>
---
 net/smc/smc_ism.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
index 9c6e95882553..4dcc236d562e 100644
--- a/net/smc/smc_ism.c
+++ b/net/smc/smc_ism.c
@@ -460,7 +460,6 @@ void smcd_unregister_dev(struct smcd_dev *smcd)
 	mutex_unlock(&smcd_dev_list.mutex);
 	smcd->going_away = 1;
 	smc_smcd_terminate_all(smcd);
-	flush_workqueue(smcd->event_wq);
 	destroy_workqueue(smcd->event_wq);
 
 	device_del(&smcd->dev);
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help