On Mon, 31 May 2021 14:09:56 +0300 Maxim Mikityanskiy wrote:

On 2021-05-28 22:44, Jakub Kicinski wrote:

quoted

In general "someone may miss this in the future" is better served by
adding a test case than code duplication. But we don't have infra to
fake-offload TLS so I don't feel strongly. You can keep as is if that's
your preference.  

Yeah, I agree that we would benefit from having unit tests for such 
flows. But as we don't have the needed infrastructure, and you are fine 
with the current implementation, I'll keep it. The only thing I need to 
fix when resubmitting is the unneeded EXPORT_SYMBOL_GPL, right?

Yup!