Re: [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register
From: Patrick Menschel <hidden>
Date: 2021-05-07 08:22:05
Also in:
linux-can
From: Patrick Menschel <hidden>
Date: 2021-05-07 08:22:05
Also in:
linux-can
Am 07.05.21 um 09:25 schrieb Marc Kleine-Budde:
On 22.04.2021 09:18:54, Marc Kleine-Budde wrote:quoted
On 4/21/21 9:58 PM, Drew Fustini wrote:quoted
I am encountering similar error with the 5.10 raspberrypi kernel on RPi 4 with MCP2518FD: mcp251xfd spi0.0 can0: CRC read error at address 0x0010 (length=4, data=00 ad 58 67, CRC=0xbbfd) retryingWhat's the situation you see these errors? I'm not particular happy with that patch, as it only works around that one particular bit flip issue. If you really hammer the register, the driver will still notice CRC errors that can be explained by other bits flipping. Consider this as the first order approximation of a higher order problem :) - the root cause is still unknown.quoted
Would it be possible for you to pull these patches into a v5.10 branch in your linux-rpi repo [1]?Here you are: https://github.com/marckleinebudde/linux-rpi/tree/v5.10-rpi/backport-performance-improvements I've included the UINC performance enhancements, too. The branch is compiled tested only, though. I'll send a pull request to the rpi kernel after I've testing feedback from you.Drew, Patrick, have you tested this branch? If so I'll send a pull request to the raspi kernel.
Sorry Marc, not yet. Thanks for reminding me. I'll start a native build on a pi0w asap. Is there any test application or stress test that I should run? Regards, Patrick