Re: [PATCH net] can: mcp251xfd: fix an error pointer dereference in probe
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-05-03 14:53:31
Also in:
kernel-janitors, linux-can
On 03.05.2021 17:49:09, Dan Carpenter wrote:
When we converted this code to use dev_err_probe() we accidentally
removed a return. It means that if devm_clk_get() it will lead to
an Oops when we call clk_get_rate() on the next line.
Fixes: cf8ee6de2543 ("can: mcp251xfd: mcp251xfd_probe(): use dev_err_probe() to simplify error handling")
Signed-off-by: Dan Carpenter <redacted>Good catch, found that yesterday, too, but haven't posted it here. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachments
- signature.asc [application/pgp-signature] 488 bytes