[Patch bpf v2 4/7] skmsg: fix a memory leak in sk_psock_verdict_apply()
flat view
STALE1980d
SUPERSEDED
From: Cong Wang <hidden>
Date: 2021-05-22 19:14:34
Also in:
bpf
Subsystem:
bpf [l7 framework] (sockmap), networking [general], the rest · Maintainers:
John Fastabend, Jakub Sitnicki, Jiayuan Chen, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Status: Superseded by v3 (posted 2021-05-27). [go to v3]
Revision v2 (2 revisions archived).
Revisions (2)
- v2 current
- v3 [diff against previous] re-posted go to this post
From: Cong Wang <redacted>
If the dest psock does not set SK_PSOCK_TX_ENABLED,
then the skb can't be queued anywhere so hould be
dropped.
This one is found during code review.
Fixes: 799aa7f98d53 ("skmsg: Avoid lock_sock() in sk_psock_backlog()")
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Lorenz Bauer <redacted>
Signed-off-by: Cong Wang <redacted>
---
net/core/skmsg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/core/skmsg.c b/net/core/skmsg.c
index f9a81b314e4c..de68a3cd33f1 100644
--- a/net/core/skmsg.c
+++ b/net/core/skmsg.c@@ -922,8 +922,11 @@ static void sk_psock_verdict_apply(struct sk_psock *psock, if (sk_psock_test_state(psock, SK_PSOCK_TX_ENABLED)) { skb_queue_tail(&psock->ingress_skb, skb); schedule_work(&psock->work); + err = 0; } spin_unlock_bh(&psock->ingress_lock); + if (err < 0) + goto out_free; } break; case __SK_REDIRECT:
--
2.25.1