Re: [PATCH net 0/6] bridge: Fix snooping in multi-bridge config with switchdev
From: Huang, Joseph <hidden>
Date: 2021-05-04 20:38:03
Also in:
bridge, lkml
From: Huang, Joseph <hidden>
Date: 2021-05-04 20:38:03
Also in:
bridge, lkml
Hi, This patch-set is inappropriate for -net, if at all. It's quite late over here and I'll review the rest later, but I can say from a quick peek that patch 02 is unacceptable for it increases the complexity with 1 order of magnitude of all add/del call paths and some of them can be invoked on user packets. A lot of this functionality should be "hidden" in the driver or done by a user-space daemon/helper. Most of the flooding behaviour changes must be hidden behind some new option otherwise they'll break user setups that rely on the current. I'll review the patches in detail over the following few days, net-next is closed anyway. Cheers, Nik
Hi Nik, Thanks for your quick response! Once you have a chance to review the set, please let me know how I can improve them to make them acceptable. These are real problems and we do need to fix them. Thanks, Joseph