Thread (3 messages) flat view 3 messages, 3 authors, 2021-05-03

Re: [PATCH v2] ethernet:enic: Fix a use after free bug in enic_hard_start_xmit

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-05-03 20:30:17
Also in: lkml

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun,  2 May 2021 04:58:18 -0700 you wrote:
In enic_hard_start_xmit, it calls enic_queue_wq_skb(). Inside
enic_queue_wq_skb, if some error happens, the skb will be freed
by dev_kfree_skb(skb). But the freed skb is still used in
skb_tx_timestamp(skb).

My patch makes enic_queue_wq_skb() return error and goto spin_unlock()
incase of error. The solution is provided by Govind.
See https://lkml.org/lkml/2021/4/30/961.

[...]
Here is the summary with links:
  - [v2] ethernet:enic: Fix a use after free bug in enic_hard_start_xmit
    https://git.kernel.org/netdev/net/c/643001b47adc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help