[PATCH net-next] sctp: sm_statefuns: Fix spelling mistakes

Subsystems: networking [general], sctp protocol, the rest

STALE1951d

3 messages, 2 authors, 2021-06-01 · open the first message on its own page

[PATCH net-next] sctp: sm_statefuns: Fix spelling mistakes

From: Zheng Yongjun <hidden>
Date: 2021-05-31 01:47:39

Fix some spelling mistakes in comments:
genereate ==> generate
correclty ==> correctly
boundries ==> boundaries
failes ==> fails

Signed-off-by: Zheng Yongjun <redacted>
---
 net/sctp/sm_statefuns.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index fd1e319eda00..68e7d14c3799 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c

@@ -608,7 +608,7 @@ enum sctp_disposition sctp_sf_do_5_1C_ack(struct net *net,
 	sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE,
 			SCTP_STATE(SCTP_STATE_COOKIE_ECHOED));
 
-	/* SCTP-AUTH: genereate the assocition shared keys so that
+	/* SCTP-AUTH: generate the assocition shared keys so that
 	 * we can potentially signe the COOKIE-ECHO.
 	 */
 	sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_SHKEY, SCTP_NULL());

@@ -838,7 +838,7 @@ enum sctp_disposition sctp_sf_do_5_1D_ce(struct net *net,
 
 	/* Add all the state machine commands now since we've created
 	 * everything.  This way we don't introduce memory corruptions
-	 * during side-effect processing and correclty count established
+	 * during side-effect processing and correctly count established
 	 * associations.
 	 */
 	sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc));

@@ -2950,7 +2950,7 @@ enum sctp_disposition sctp_sf_do_9_2_reshutack(
 						  commands);
 
 	/* Since we are not going to really process this INIT, there
-	 * is no point in verifying chunk boundries.  Just generate
+	 * is no point in verifying chunk boundaries.  Just generate
 	 * the SHUTDOWN ACK.
 	 */
 	reply = sctp_make_shutdown_ack(asoc, chunk);

@@ -3560,7 +3560,7 @@ enum sctp_disposition sctp_sf_do_9_2_final(struct net *net,
 		goto nomem_chunk;
 
 	/* Do all the commands now (after allocation), so that we
-	 * have consistent state if memory allocation failes
+	 * have consistent state if memory allocation fails
 	 */
 	sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, SCTP_ULPEVENT(ev));

-- 
2.25.1

Re: [PATCH net-next] sctp: sm_statefuns: Fix spelling mistakes

From: Xin Long <lucien.xin@gmail.com>
Date: 2021-05-31 17:30:49

On Sun, May 30, 2021 at 9:48 PM Zheng Yongjun [off-list ref] wrote:

Fix some spelling mistakes in comments:
genereate ==> generate
correclty ==> correctly
boundries ==> boundaries
failes ==> fails

I believe more mistakes below in this file could hitchhike this patch
to get fixed. :-)

isses -> issues
assocition -> association
signe -> sign
assocaition -> association
managemement-> management
restransmissions->retransmission
sideffect -> sideeffect
bomming -> booming
chukns-> chunks
SHUDOWN -> SHUTDOWN
violationg->violating
explcitly-> explicitly
CHunk-> Chunk

Thanks.

quoted hunk

Signed-off-by: Zheng Yongjun <redacted>
---
 net/sctp/sm_statefuns.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index fd1e319eda00..68e7d14c3799 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c

@@ -608,7 +608,7 @@ enum sctp_disposition sctp_sf_do_5_1C_ack(struct net *net,
        sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE,
                        SCTP_STATE(SCTP_STATE_COOKIE_ECHOED));

-       /* SCTP-AUTH: genereate the assocition shared keys so that
+       /* SCTP-AUTH: generate the assocition shared keys so that
         * we can potentially signe the COOKIE-ECHO.
         */
        sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_SHKEY, SCTP_NULL());

@@ -838,7 +838,7 @@ enum sctp_disposition sctp_sf_do_5_1D_ce(struct net *net,

        /* Add all the state machine commands now since we've created
         * everything.  This way we don't introduce memory corruptions
-        * during side-effect processing and correclty count established
+        * during side-effect processing and correctly count established
         * associations.
         */
        sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc));

@@ -2950,7 +2950,7 @@ enum sctp_disposition sctp_sf_do_9_2_reshutack(
                                                  commands);

        /* Since we are not going to really process this INIT, there
-        * is no point in verifying chunk boundries.  Just generate
+        * is no point in verifying chunk boundaries.  Just generate
         * the SHUTDOWN ACK.
         */
        reply = sctp_make_shutdown_ack(asoc, chunk);

@@ -3560,7 +3560,7 @@ enum sctp_disposition sctp_sf_do_9_2_final(struct net *net,
                goto nomem_chunk;

        /* Do all the commands now (after allocation), so that we
-        * have consistent state if memory allocation failes
+        * have consistent state if memory allocation fails
         */
        sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, SCTP_ULPEVENT(ev));

--

2.25.1

答复: [PATCH net-next] sctp: sm_statefuns: Fix spelling mistakes

From: zhengyongjun <hidden>
Date: 2021-06-01 01:53:45

Thanks for your advice, I will fix it as you suggest and send patch v2 :)

-----邮件原件-----
发件人: Xin Long [mailto:lucien.xin@gmail.com] 
发送时间: 2021年6月1日 0:24
收件人: zhengyongjun [off-list ref]
抄送: Vlad Yasevich [off-list ref]; Neil Horman [off-list ref]; Marcelo Ricardo Leitner [off-list ref]; davem [off-list ref]; Jakub Kicinski [off-list ref]; linux-sctp @ vger . kernel . org [off-list ref]; network dev [off-list ref]; LKML [off-list ref]
主题: Re: [PATCH net-next] sctp: sm_statefuns: Fix spelling mistakes

On Sun, May 30, 2021 at 9:48 PM Zheng Yongjun [off-list ref] wrote:

Fix some spelling mistakes in comments:
genereate ==> generate
correclty ==> correctly
boundries ==> boundaries
failes ==> fails

I believe more mistakes below in this file could hitchhike this patch to get fixed. :-)

isses -> issues
assocition -> association
signe -> sign
assocaition -> association
managemement-> management
restransmissions->retransmission
sideffect -> sideeffect
bomming -> booming
chukns-> chunks
SHUDOWN -> SHUTDOWN
violationg->violating
explcitly-> explicitly
CHunk-> Chunk

Thanks.

quoted hunk

Signed-off-by: Zheng Yongjun <redacted>
---
 net/sctp/sm_statefuns.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index

fd1e319eda00..68e7d14c3799 100644

--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c

@@ -608,7 +608,7 @@ enum sctp_disposition sctp_sf_do_5_1C_ack(struct net *net,
        sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE,
                        SCTP_STATE(SCTP_STATE_COOKIE_ECHOED));

-       /* SCTP-AUTH: genereate the assocition shared keys so that
+       /* SCTP-AUTH: generate the assocition shared keys so that
         * we can potentially signe the COOKIE-ECHO.
         */
        sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_SHKEY, SCTP_NULL());

@@ -838,7 +838,7 @@ enum sctp_disposition sctp_sf_do_5_1D_ce(struct

net *net,

        /* Add all the state machine commands now since we've created
         * everything.  This way we don't introduce memory corruptions
-        * during side-effect processing and correclty count established
+        * during side-effect processing and correctly count 
+ established
         * associations.
         */
        sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, 
SCTP_ASOC(new_asoc)); @@ -2950,7 +2950,7 @@ enum sctp_disposition sctp_sf_do_9_2_reshutack(
                                                  commands);

        /* Since we are not going to really process this INIT, there
-        * is no point in verifying chunk boundries.  Just generate
+        * is no point in verifying chunk boundaries.  Just generate
         * the SHUTDOWN ACK.
         */
        reply = sctp_make_shutdown_ack(asoc, chunk); @@ -3560,7 
+3560,7 @@ enum sctp_disposition sctp_sf_do_9_2_final(struct net *net,
                goto nomem_chunk;

        /* Do all the commands now (after allocation), so that we
-        * have consistent state if memory allocation failes
+        * have consistent state if memory allocation fails
         */
        sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, 
SCTP_ULPEVENT(ev));

--
2.25.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help