Thread (3 messages) flat view 3 messages, 3 authors, 2021-05-28

RE: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()

From: John Fastabend <john.fastabend@gmail.com>
Date: 2021-05-28 04:02:36
Also in: bpf, lkml

Hangbin Liu wrote:
As Colin pointed out, the first drops assignment after declaration will
be overwritten by the second drops assignment before using, which makes
it useless.

Since the drops variable will be used only once. Just remove it and
use "cnt - sent" in trace_xdp_devmap_xmit()

Reported-by: Colin Ian King <redacted>
Fixes: cb261b594b41 ("bpf: Run devmap xdp_prog on flush instead of bulk enqueue")
Signed-off-by: Hangbin Liu <redacted>
---
 kernel/bpf/devmap.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
Thanks

Acked-by: John Fastabend <john.fastabend@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help