RE: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel mGbE controller

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Friday, 28 May, 2021 7:27 AM
To: Sit, Michael Wei Hong <redacted>
Cc: Jose.Abreu@synopsys.com; hkallweit1@gmail.com;
linux@armlinux.org.uk; kuba@kernel.org;
netdev@vger.kernel.org; peppe.cavallaro@st.com;
alexandre.torgue@foss.st.com; davem@davemloft.net;
mcoquelin.stm32@gmail.com; Voon, Weifeng
[off-list ref]; Ong, Boon Leong
[off-list ref]; Tan, Tee Min
[off-list ref]; vee.khee.wong@linux.intel.com;
Wong, Vee Khee [off-list ref]; linux-stm32@st-
md-mailman.stormreply.com; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX
support for Intel mGbE controller

quoted

+static int xpcs_config_2500basex(struct mdio_xpcs_args *xpcs)

{

quoted

+	int ret;
+
+		ret = xpcs_read(xpcs, MDIO_MMD_VEND2,

DW_VR_MII_DIG_CTRL1);

quoted

+		if (ret < 0)
+			return ret;
+		ret |= DW_VR_MII_DIG_CTRL1_2G5_EN;
+		ret &=

~DW_VR_MII_DIG_CTRL1_MAC_AUTO_SW;

quoted

+		ret = xpcs_write(xpcs, MDIO_MMD_VEND2,

DW_VR_MII_DIG_CTRL1, ret);

quoted

+		if (ret < 0)
+			return ret;
+
+		ret = xpcs_read(xpcs, MDIO_MMD_VEND2,

DW_VR_MII_MMD_CTRL);

quoted

+		if (ret < 0)
+			return ret;
+		ret &= ~AN_CL37_EN;
+		ret |= SGMII_SPEED_SS6;
+		ret &= ~SGMII_SPEED_SS13;
+		return xpcs_write(xpcs, MDIO_MMD_VEND2,

DW_VR_MII_MMD_CTRL, ret);

quoted

+
+	return 0;

Indentation is messed up here? Or a rebase gone wrong
removing an if statement?

Thanks Andrew! Good catch, missed this indentation error,
will fix in next revision

	    Andrew