Re: [PATCH net] net: phy: Document phydev::dev_flags bits allocation

On Wed, May 26, 2021 at 08:53:41PM +0200, Andrew Lunn wrote:

On Wed, May 26, 2021 at 11:46:17AM -0700, Florian Fainelli wrote:

quoted

Document the phydev::dev_flags bit allocation to allow bits 15:0 to
define PHY driver specific behavior, bits 23:16 to be reserved for now,
and bits 31:24 to hold generic PHY driver flags.

This is good as far as it goes. But do we want to give a hint that if
the MAC driver sets bits in [15:0] it should first verify the PHY has
the ID which is expected?

Hi Andrew,

I think we probably need a helper for that - while we can match
phydev->phy_id, that only works for C22 PHYs. Matching the C45
IDs is much more painful. So, I think a helper would be good,
even if initially it just checks the C22 ID.

Thoughts?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!