RE: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations

Hi Andrew,

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: 2021年5月23日 22:39
To: Joakim Zhang <redacted>
Cc: davem@davemloft.net; kuba@kernel.org; frieder.schrempf@kontron.de;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
[off-list ref]
Subject: Re: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX
bandwidth fluctuations

quoted

@@ -76,6 +76,8 @@ static void fec_enet_itr_coal_init(struct net_device

*ndev);

quoted

 #define DRIVER_NAME	"fec"

+static const u16 fec_enet_vlan_pri_to_queue[8] = {1, 1, 1, 1, 2, 2, 2, 2};

I wonder if priority 0 should be sent to queue 0?

Yes, we can. But the original thought of author seems to, VLAN tagged packets only use queue 1&2, and queue 0is reserved for VLAN untagged packets.

Best Regards,
Joakim Zhang

  Andrew