Thread (35 messages) 35 messages, 6 authors, 2021-06-14

Re: [PATCH] genirq: Provide new interfaces for affinity hints

From: Thomas Gleixner <hidden>
Date: 2021-05-21 21:45:37
Also in: intel-wired-lan, linux-api, linux-pci, lkml

On Fri, May 21 2021 at 10:45, Lijun Pan wrote:
On Fri, May 21, 2021 at 7:48 AM Thomas Gleixner [off-list ref] wrote:
quoted
+/**
+ * irq_update_affinity_hint - Update the affinity hint
+ * @irq:       Interrupt to update
+ * @cpumask:   cpumask pointer (NULL to clear the hint)
+ *
+ * Updates the affinity hint, but does not change the affinity of the interrupt.
+ */
+static inline int
+irq_update_affinity_hint(unsigned int irq, const struct cpumask *m)
+{
+       return __irq_apply_affinity_hint(irq, m, true);
+}
Should it be:
return __irq_apply_affinity_hint(irq, m, false);
here?
Of course. Copy & Pasta should be forbidden.

Thanks for spotting it!

       tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help