Thread (2 messages) flat view 2 messages, 2 authors, 2021-05-13

Re: [PATCH] net: caif: Drop unnecessary NULL check after container_of

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-05-13 23:00:24
Also in: lkml

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 13 May 2021 09:58:40 -0700 you wrote:
The first parameter passed to chnl_recv_cb() can never be NULL since all
callers dereferenced it. Consequently, container_of() on it is also never
NULL, even though the reference into the structure points to the first
element of the structure. The NULL check is therefore unnecessary.
On top of that, it is misleading to perform a NULL check on the result of
container_of() because the position of the contained element could change,
which would make the test invalid. Remove the unnecessary NULL check.

[...]
Here is the summary with links:
  - net: caif: Drop unnecessary NULL check after container_of
    https://git.kernel.org/netdev/net-next/c/0f3ee280331e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help