Re: [PATCH V2] net: mdio: thunder: Fix a double free issue in the .remove function
flat view
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2021-05-13 08:11:49
Also in:
kernel-janitors, lkml
On Thu, May 13, 2021 at 09:44:49AM +0200, Christophe JAILLET wrote:
'bus->mii_bus' have been allocated with 'devm_mdiobus_alloc_size()' in the probe function. So it must not be freed explicitly or there will be a double free. Remove the incorrect 'mdiobus_free' in the remove function.
This still leaves the unregister of an allocated-but-unregistered bus, which you disagreed with - but I hope as I've pointed out the exact code path in your v1 patch, you'll now realise is a real possibility. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!