Re: [PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique_tag() to generate requestIDs
From: Wei Liu <wei.liu@kernel.org>
Date: 2021-05-10 17:34:09
Also in:
linux-hyperv, linux-scsi, lkml
From: Wei Liu <wei.liu@kernel.org>
Date: 2021-05-10 17:34:09
Also in:
linux-hyperv, linux-scsi, lkml
On Thu, May 06, 2021 at 05:45:16PM +0000, Wei Liu wrote:
On Thu, Apr 15, 2021 at 01:22:32PM +0000, Michael Kelley wrote:quoted
From: Andrea Parri (Microsoft) <parri.andrea@gmail.com> Sent: Thursday, April 15, 2021 3:59 AMquoted
Use blk_mq_unique_tag() to generate requestIDs for StorVSC, avoiding all issues with allocating enough entries in the VMbus requestor. Suggested-by: Michael Kelley <redacted> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> --- Changes since RFC: - pass sentinel values for {init,reset}_request in vmbus_sendpacket() - remove/inline the storvsc_request_addr() callback - make storvsc_next_request_id() 'static' - add code to handle the case of an unsolicited message from Hyper-V - other minor/style changes [1] https://lore.kernel.org/linux-hyperv/20210408161315.341888-1-parri.andrea@gmail.com/ (local) drivers/hv/channel.c | 14 ++--- drivers/hv/ring_buffer.c | 13 +++-- drivers/net/hyperv/netvsc.c | 8 ++- drivers/net/hyperv/rndis_filter.c | 2 + drivers/scsi/storvsc_drv.c | 94 +++++++++++++++++++++---------- include/linux/hyperv.h | 13 ++++- 6 files changed, 95 insertions(+), 49 deletions(-)LGTM Reviewed-by: Michael Kelley <redacted>Although this patch is tagged with SCSI, I think it would be better if this goes through the hyperv tree. Let me know if there is any objection.
Andrea, please rebase this patch on top of hyperv-next. It does not apply as-is. Wei.