Thread (1 message) flat view 1 message, 1 author, 2021-05-10

Re: Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning

From: Fabio Aiuto <hidden>
Date: 2021-05-10 15:22:35
Also in: linux-staging, lkml

Hi Ashish,

in your subject line there is one Subject: too many

On Mon, May 10, 2021 at 08:13:37PM +0530, Ashish Vara wrote:
quoted hunk
From: Ashish Vara <redacted>

removed unnecessary out of memory message to fix coding style warning.

Signed-off-by: Ashish Vara <redacted>
---
 drivers/staging/qlge/qlge_main.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index c9dc6a852af4..a9e0bccc52d0 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -2796,12 +2796,8 @@ static int qlge_init_bq(struct qlge_bq *bq)
 
 	bq->base = dma_alloc_coherent(&qdev->pdev->dev, QLGE_BQ_SIZE,
 				      &bq->base_dma, GFP_ATOMIC);
-	if (!bq->base) {
-		netif_err(qdev, ifup, qdev->ndev,
-			  "ring %u %s allocation failed.\n", rx_ring->cq_id,
-			  bq_type_name[bq->type]);
+	if (!bq->base)
 		return -ENOMEM;
-	}
 
 	bq->queue = kmalloc_array(QLGE_BQ_LEN, sizeof(struct qlge_bq_desc),
 				  GFP_KERNEL);
-- 
2.30.2
thank you,

fabio
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help