On Fri, 28 May 2021 16:48:17 +0000 Nguyen, Anthony L wrote:

On Fri, 2021-05-28 at 10:02 -0300, Jason Gunthorpe wrote:

quoted

quoted

defensive programming  

Will remove this.

quoted

quoted

RDMA folks, are you okay with drivers inventing their own error
codes?  

Not really, I was ignoring it because it looks like big part of their
netdev driver layer.  

We have looked into how we can eliminate/minimize the use of ice_status
and our assessment is that this will take a decent amount of work. We
are trying to get this done.

Sorry I don't speak managerese.

I asked you to stop using your own error codes multiple times, and 
now you're about to pollute another subsystem with the same problem.

Please fix.