Thread (6 messages) flat view 6 messages, 4 authors, 2021-05-19

Re: [PATCH net-next v2 2/2] usb: class: cdc-wdm: WWAN framework integration

From: Aleksander Morgado <hidden>
Date: 2021-05-19 09:40:13

quoted
But another thought: why couldn't wwan_create_port() take a devname
template like alloc_netdev() does and cdc-wdm can just pass "cdc-
wdm%d"? eg, why do we need to change the name?
Tools that care about
finding WWAN devices should be looking at sysfs attributes/links and
TYPE=XXXX in uevent, not at the device name. Nothing should be looking
at device name really.
Right, passing the legacy cdc-wdm dev-name as a parameter seems to be
a fair solution, making the transition smoother.
Reusing the cdc-wdm name is indeed a good compromise; plus then
reading port type (QMI, MBIM...) via sysfs attributes as you suggested
in your last patch would make it work perfectly fine in userspace.

-- 
Aleksander
https://aleksander.es
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help