Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-05-18 17:30:59
On Tue, 18 May 2021 14:48:13 +0800 huangguangbin (A) wrote:
On 2021/4/16 6:53, Jakub Kicinski wrote:quoted
This set adds uAPI for reporting standard FEC statistics, and implements it in a handful of drivers. The statistics are taken from the IEEE standard, with one extra seemingly popular but not standard statistics added. The implementation is similar to that of the pause frame statistics, user requests the stats by setting a bit (ETHTOOL_FLAG_STATS) in the common ethtool header of ETHTOOL_MSG_FEC_GET. Since standard defines the statistics per lane what's reported is both total and per-lane counters: # ethtool -I --show-fec eth0 FEC parameters for eth0: Configured FEC encodings: None Active FEC encoding: None Statistics: corrected_blocks: 256 Lane 0: 255 Lane 1: 1 uncorrectable_blocks: 145 Lane 0: 128 Lane 1: 17Hi, I have a doubt that why active FEC encoding is None here? Should it actually be BaseR or RS if FEC statistics are reported?
Hi! Good point. The values in the example are collected from a netdevsim based mock up which I used for testing the interface, not real hardware. In reality seeing None and corrected/uncorrectable blocks is not valid. That said please keep in mind that the statistics should not be reset when settings are changed, so OFF + stats may happen.