These TODO empty code are added by
commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
been more than a decade now. I don't think anyone who wants to perfect
this workaround can follow this TODO tip exactly. Instead, it limits them
to new thinking. Remove it will be better.
No functional change.
Signed-off-by: Zhen Lei <redacted>
---
drivers/net/wireless/broadcom/b43/phy_n.c | 16 ----------------
1 file changed, 16 deletions(-)
@@ -4601,16 +4601,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev)if(nphy->hang_avoid)b43_nphy_stay_in_carrier_search(dev,1);-if(nphy->gband_spurwar_en){-/* TODO: N PHY Adjust Analog Pfbw (7) */-if(channel==11&&b43_is_40mhz(dev)){-;/* TODO: N PHY Adjust Min Noise Var(2, tone, noise)*/-}else{-;/* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/-}-/* TODO: N PHY Adjust CRS Min Power (0x1E) */-}-if(nphy->aband_spurwar_en){if(channel==54){tone[0]=0x20;
@@ -4636,12 +4626,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev)tone[0]=0;noise[0]=0;}--if(!tone[0]&&!noise[0]){-;/* TODO: N PHY Adjust Min Noise Var(1, tone, noise)*/-}else{-;/* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/-}}if(nphy->hang_avoid)
From: kernel test robot <hidden> Date: 2021-05-10 17:22:54
Hi Zhen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master v5.13-rc1 next-20210510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhen-Lei/b43-phy_n-Delete-some-useless-empty-code/20210510-225502
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-randconfig-s022-20210510 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/0a34ec34888436b132760d1f4f9aa7b0e8f84488
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zhen-Lei/b43-phy_n-Delete-some-useless-empty-code/20210510-225502
git checkout 0a34ec34888436b132760d1f4f9aa7b0e8f84488
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>
All warnings (new ones prefixed by >>):
drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_spur_workaround':
quoted
drivers/net/wireless/broadcom/b43/phy_n.c:4597:6: warning: variable 'noise' set but not used [-Wunused-but-set-variable]
4597 | u32 noise[2] = { 0x3FF, 0x3FF };
| ^~~~~
quoted
drivers/net/wireless/broadcom/b43/phy_n.c:4596:6: warning: variable 'tone' set but not used [-Wunused-but-set-variable]
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-05-10 20:02:49
On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
These TODO empty code are added by
commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
been more than a decade now. I don't think anyone who wants to perfect
this workaround can follow this TODO tip exactly. Instead, it limits them
to new thinking. Remove it will be better.
No functional change.
No function change, apart from the new warning?
Does your bot to compile the change and look for new warnings/errors?
Andrew
On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
quoted
These TODO empty code are added by
commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
been more than a decade now. I don't think anyone who wants to perfect
this workaround can follow this TODO tip exactly. Instead, it limits them
to new thinking. Remove it will be better.
No functional change.
No function change, apart from the new warning?
Does your bot to compile the change and look for new warnings/errors?
Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it.
On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
quoted
These TODO empty code are added by
commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
been more than a decade now. I don't think anyone who wants to perfect
this workaround can follow this TODO tip exactly. Instead, it limits them
to new thinking. Remove it will be better.
No functional change.
No function change, apart from the new warning?
Does your bot to compile the change and look for new warnings/errors?
Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it.
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-05-11 12:04:50
I got it. It reported by W=1.
A lot of the kernel tree is W=1 clean now. Networking is. So we expect
patches to also be W=1 clean.
Hopefully this will become the default at some point, or the
additional warnings W=1 enables will be made always be enabled.
Andrew