On Sat, 2021-05-01 at 16:50 +0300, Nikolai Zhubr wrote:

Hi Johannes,

01.05.2021 3:01, I wrote:
[...]

quoted

quoted

https://p.sipsolutions.net/5adbe659fb061f06.txt

Is it supposed to work correctly for unmodified 5.12 kernel? Because it

Success! I've found an apparently missing mutex_unlock() in alx_probe() 
just before the "return 0" line.

D'oh, right, missed that place.

With that inserted, your patch indeed 
fixes the 120 s boot delay here. And the link apparenly also works fine 
after boot, in normal operation.
Can it be somehow reviewed and submitted unstream please?
I'd like it also ported to 4.xx then. (Maybe I can port myself though)

Well I don't think anyone's going to still backport such a patch to a
4.x kernel, but of course you can.

I guess I can see about making it a real patch, should only take a
little while to audit (again) the hardware access paths wrt. locking.

johannes